Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.167、168、243、244】 Migrate pooling ops into pir #58700

Merged
merged 9 commits into from
Nov 29, 2023
Merged

【PIR API adaptor No.167、168、243、244】 Migrate pooling ops into pir #58700

merged 9 commits into from
Nov 29, 2023

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Nov 5, 2023

PR types

Others

PR changes

APIs

Description

No.167、168、243、244
PIR API 推全升级

  • AdaptiveAvgPool1D
  • AvgPool1D
  • AdaptiveAvgPool3D
  • AvgPool3D
  • MaxUnPool1D
  • MaxUnPool2D
  • MaxUnPool3D

  • 新IR Python API适配升级 #58067
  • test_pool1d_api 单测通过率100%
  • test_pool2d_api 单测通过率100%
  • test_pool3d_api 单测通过率100%
  • test_pool3d_op 单测通过率100%
  • test_unpool_op 单测通过率100%
  • test_unpool1d_op 单测通过率100%
  • test_unpool3d_op 单测通过率100%

@0x45f
Copy link
Contributor

0x45f commented Nov 17, 2023

先检查一下API内部代码是否有的代码没有适配pir,以及单测内是否调用了没有适配pir的API~

@0x45f
Copy link
Contributor

0x45f commented Nov 24, 2023

pool3d单测失败是因为pir下没有支持gpudnn机制,等到 #59344 合入后再尝试合入此PR

@MarioLulab
Copy link
Contributor

#59344 已合入,尝试 merge 最新的 develop 分支,并开启 pool3d 原先失败的单测~

@0x45f 0x45f closed this Nov 28, 2023
@0x45f 0x45f reopened this Nov 28, 2023
@0x45f 0x45f merged commit e7fdaf9 into PaddlePaddle:develop Nov 29, 2023
28 checks passed
@DrRyanHuang DrRyanHuang deleted the pooling branch November 29, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants